feat(NumberTheory/NumberField/Completion/FinitePlace): compatibility of finite places across an algebra map#41604
Open
tb65536 wants to merge 2 commits into
Open
feat(NumberTheory/NumberField/Completion/FinitePlace): compatibility of finite places across an algebra map#41604tb65536 wants to merge 2 commits into
tb65536 wants to merge 2 commits into
Conversation
tb65536
added
awaiting-CI
PR summary 7a14eabe66
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.NumberTheory.NumberField.Completion.FinitePlace | 3170 | 3171 | +1 (+0.03%) |
Import changes for all files
| Files | Import difference |
|---|---|
5 filesMathlib.AlgebraicGeometry.EllipticCurve.LFunction Mathlib.NumberTheory.Height.NumberField Mathlib.NumberTheory.NumberField.Completion.FinitePlace Mathlib.NumberTheory.NumberField.FinitePlaces Mathlib.NumberTheory.NumberField.ProductFormula |
1 |
Declarations diff (regex)
+ equivHeightOneSpectrum_symm_apply_algebraMap
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit
7a14eab).
- +1 new declarations
- −0 removed declarations
+NumberField.FinitePlace.equivHeightOneSpectrum_symm_apply_algebraMapNo changes to strong technical debt.
No changes to weak technical debt.
Current commit 7a14eabe66
Reference commit a33a5ccd63
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
github-actions
Bot
removed
the
awaiting-CI
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given an extension of finite places, this PR proves compatibility across an algebra map. Eventually it would be nice to have a version stated purely in terms of
FinitePlace, but we are lacking the ramification theory of finite places required for this (I have larger plans to do ramification theory for absolute values more generally, but this will take some time).